Comment cleanup (includes #131)#149
Open
thejpster wants to merge 6 commits intorust-embedded:mainfrom
Open
Conversation
|
I'm curious. Did you write all of these or is this generated from some other source? |
Contributor
Author
|
Mostly copy-pasted from the arm Arm ARM. |
thejpster
force-pushed
the
comment-cleanup
branch
from
f6b292d to
8726af0
Compare
jonathanpallant
force-pushed
the
comment-cleanup
branch
from
8726af0 to
580a9ce
Compare
Contributor
|
I am a bit confused. This was rebased, but I thought this only includes docs updates, but I still see various new test cases etc. in the changes? |
Contributor
|
Ah, I get it. #131 was not merged yet :) |
Contributor
|
#131 is in so I'll rebase this |
thejpster
force-pushed
the
comment-cleanup
branch
from
580a9ce to
ad9f9ae
Compare
* Turned on deny(missing_docs), and added missing docs * Turned on deny(clippy::missing_safety_doc) and added missing safety docs * Turned on some more useful lints * Clippy fixes * Rationalised/renamed the various CachePolicy types
It's still useful for unit testing, and the CLI uses it.
It just seems to make more sense than doing a linear walk of a Vec.
thejpster
force-pushed
the
comment-cleanup
branch
from
ad9f9ae to
d351452
Compare
It all works on stable now (with RUSTC_BOOTSTRAP=1)
thejpster
force-pushed
the
comment-cleanup
branch
from
d351452 to
bf3f8f3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comment updates.
Includes #131